Re: [Qemu-devel] Comment for Solaris fix for the HPTC

[Johannes Schindelin]

Hi,

On Sun, 16 Sep 2007, Ben Taylor wrote:

> ---- Johannes Schindelin <address@hidden> wrote: 
> 
> > On Sat, 15 Sep 2007, Ben Taylor wrote:
> > 
> > > +#ifdef __sun__
> > > +/* Have to define this for Solaris as ULONG_LONG_MAX is not defined
> > > +   anywhere.  ULONG_MAX is correct only on _LP64 systems */
> > > +#define ULONG_LONG_MAX 18446744073709551615UL
> > > +#endif
> > > +
> > 
> > These constants are always defined, right?  So why not "#ifndef 
> > ULONG_LONG_MAX"?
> 
> I fear I may not have explained this well.

I fear _I_ may not have made myself very clear.  What I meant was: why not 
check if ULONG_LONG_MAX is undefined, instead of checking if __sun__ is 
defined?  That way, more than one platform might benefit from this change.

Just an idea,
Dscho