Re: [Qemu-devel] RFC: reverse-endian softmmu memory accessors

[Blue Swirl]

On 10/15/07, J. Mayer <address@hidden> wrote:
> On Sun, 2007-10-14 at 15:59 +0300, Blue Swirl wrote:
> > On 10/14/07, J. Mayer <address@hidden> wrote:
> > > Here's an updated version of the patch against current CVS.
> > > This patches provides reverse-endian, little-endian and big-endian
> > > memory accessors, available with and without softmmu. It also provides
> > > an IO_MEM_REVERSE TLB flag to allow future support of per-page
> > > endianness control, which is required by some targets CPU emulations.
> > > Having reverse-endian memory accessors also make it possible to optimise
> > > reverse-endian memory access when the target CPU has dedicated
> > > instructions. For now, it includes optimisations for the PowerPC target.
> >
> > This breaks Sparc32 softmmu, I get a black screen. Your changes to
> > target-sparc and hw/sun4m.c look fine, so the problem could be in IO?
>
> Did it worked before my commits ? I may have done something wrong during
> the merge...
> I will do more checks and more tests...

If I disable the IOSWAP code, black screen is gone. I think this is
logical: the io accessors return host CPU values, therefore no byte
swapping need to be performed.

The attached version works for me.

softmmu_reverse_endian.diff
Description: Text Data