Re: [Qemu-devel] qemu hw/pc.c target-i386/cpu.h target-i386/help...

[Dan Kenigsberg]

On Thu, Nov 08, 2007 at 01:28:47PM +0000, Fabrice Bellard wrote:
> CVSROOT:      /sources/qemu
> Module name:  qemu
> Changes by:   Fabrice Bellard <bellard>       07/11/08 13:28:47
> 
> Modified files:
>       hw             : pc.c 
>       target-i386    : cpu.h helper2.c 
> 
> Log message:
>       added -cpu option for x86 (initial patch by Dan Kenigsberg)
> 
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/hw/pc.c?cvsroot=qemu&r1=1.89&r2=1.90
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-i386/cpu.h?cvsroot=qemu&r1=1.51&r2=1.52
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-i386/helper2.c?cvsroot=qemu&r1=1.54&r2=1.55
> 

Only now did I notice this. Thanks for applying, but as Thiemo Seufer
mentioned on this list, one must correct a segfault-inducing typo:

Regards,

    Dan.

diff --git a/target-i386/helper2.c b/target-i386/helper2.c
index b46475e..67658e2 100644
--- a/target-i386/helper2.c
+++ b/target-i386/helper2.c
@@ -83,7 +83,7 @@ static void add_flagname_to_bitmaps(char *flagname, uint32_t 
*features,
             return;
         }
     for ( i = 0 ; i < 32 ; i++ ) 
-        if (ext3_features[i] && !strcmp (flagname, ext3_feature_name[i])) {
+        if (ext3_feature_name[i] && !strcmp (flagname, ext3_feature_name[i])) {
             *ext3_features |= 1 << i;
             return;
         }