qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -


From: Andreas Schwab
Subject: Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option
Date: Sun, 09 Dec 2007 19:29:49 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux)

Dan Kenigsberg <address@hidden> writes:

> +                x86_cpu_def->vendor1 = val[0] + (val[1] << 8)
> +                                     + (val[2] << 16) + (val[3] << 24);
> +                x86_cpu_def->vendor2 = val[4] + (val[5] << 8)
> +                                     + (val[6] << 16) + (val[7] << 24);
> +                x86_cpu_def->vendor3 = val[8] + (val[9] << 8)
> +                                     + (val[10] << 16) + (val[11] << 24);

That will do the wrong thing with the sign bit.

Andreas.

-- 
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]