Re: [Qemu-devel] [PATCH] Capture network traffic to a tcpdump file - updated

[Paul Brook]

On Tuesday 11 December 2007, andrzej zaborowski wrote:
> On 10/12/2007, Balazs Attila-Mihaly (Cd-MaN) <address@hidden> wrote:
> > Here goes v0.2 for my patch :-)
> > Changes
> > - now the option is a separate command line switch:
> >   -net capture,vlan=2,file=test.pcap
> > - it is also available from the monitor
> > - added some more constants / defines to avoid repeating portions of the
> > code
>
> Would it be possible to implement this as simply another vlan client
> that does the logging in it's fd_read callback?  I think this would be
> cleaner, we would avoid the special case and an additional condition
> check in every qemu_send_packet().

That's exactly what I was imagining when I suggested making it a -net option.

Paul