[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [kvm-ppc-devel] The default for char Literals diffe

From: Andre Przywara
Subject: Re: [Qemu-devel] Re: [kvm-ppc-devel] The default for char Literals differ in signedness between platforms causing us a lot of warnings
Date: Wed, 16 Jan 2008 13:59:48 +0100
User-agent: Thunderbird (X11/20070409)


> Newer gcc versions generate warnings about implicit casts between
> different signed pointers.
> That hits a lot of qemu code at least what I saw it compiling for ppc
> or x86.
> So my question is, is there already a preferred qemu approach to get
> rid of these warnings
> either the -Wno-pointer-sign solution like in the kernel or something
> else (I did not find
> anything like that in the latest cvs snapshot or on this list)?

I fixed some of these issues in qemu at least for x86[1][2], those were commited mid of December[3] . I ported these over to Xen and posted it there[4]. I don't know what's the ultimate policy regarding these problems, my solution is:
1. Change the type whenever possible.
2. Introduce casts if 1. is not applicable or would introduce more back-castings.


[1] QEMU first proposal (all in one file) with comments:
[2] QEMU reworked version (splitted up to address multiple issues)
[3] QEMU commits:
[4] Xen devel post http://lists.xensource.com/archives/html/xen-devel/2008-01/msg00185.html

Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 277-84917
----to satisfy European Law for business letters:
AMD Saxony Limited Liability Company & Co. KG,
Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Register Court Dresden: HRA 4896, General Partner authorized
to represent: AMD Saxony LLC (Wilmington, Delaware, US)
General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

reply via email to

[Prev in Thread] Current Thread [Next in Thread]