Re: [Qemu-devel] Re: [PATCH 1/5] Fix i386 Host

[Johannes Schindelin]

Hi,

On Fri, 18 Jan 2008, Alexander Graf wrote:

> On Jan 18, 2008, at 2:14 AM, consul wrote:
> 
> > It broke mingw build with gcc-3.4.2
> 
> Does it work if you change the lines I'll comment on below?

Yes, if I force the pushing and popping of ecx, it compiles 
(unfortunately, I could not test the result yet).  But does

> > > +#ifdef GCC_BREAKS_T_REGISTER
> > > +                  : "%eax", "%edx", "memory", "cc");
> > > +#else
> > >                 : "%eax", "%ecx", "%edx", "memory", "cc");
> > > +#endif

not make

> > > +#ifdef GCC_BREAKS_T_REGISTER
> > > +                  "pushl %%ecx\n"
> > > +#endif

and

> > > +#ifdef GCC_BREAKS_T_REGISTER
> > > +                  "popl %%ecx\n"
> > > +#endif

obsolete (it's been a long time since I did assembler stuff, so forgive 
me this stupid question)?

Ciao,
Dscho