[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v
From: |
Izik Eidus |
Subject: |
[Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2) |
Date: |
Mon, 04 Feb 2008 10:45:48 +0200 |
On Sun, 2008-02-03 at 19:56 -0600, Anthony Liguori wrote:
> Hi Izik,
Hi
>
> Anthony Liguori wrote:
> > Index: qemu/cpu-all.h
> > ===================================================================
> > --- qemu.orig/cpu-all.h 2008-02-01 15:24:45.000000000 -0600
> > +++ qemu/cpu-all.h 2008-02-01 15:28:48.000000000 -0600
> > @@ -695,7 +695,7 @@
> >
> > /* page related stuff */
> >
> > -#define TARGET_PAGE_SIZE (1 << TARGET_PAGE_BITS)
> > +#define TARGET_PAGE_SIZE (1ul << TARGET_PAGE_BITS)
> > #define TARGET_PAGE_MASK ~(TARGET_PAGE_SIZE - 1)
> > #define TARGET_PAGE_ALIGN(addr) (((addr) + TARGET_PAGE_SIZE - 1) &
> > TARGET_PAGE_MASK
>
> Do you recall what this change fixed? As Paul pointed out in IRC, using
> the host type here doesn't really fix the problem (target_ulong would be
> more appropriate). However, we're both curious what problem it's
> actually fixing since sign extending the int should just work.
ok the commit say:
kvm: qemu: change the type of the various page masks to unsigned long
prevents truncation with >=4GB of guest physical memory
as far as i remember it was used to address something with
cpu_physical_memory_rw() probably related to &TARGET_PAGE_SIZE
or ~TARGET_PAGE_SIZE,
the fact is that i dont know if it ever fixed anything
- [Qemu-devel] [PATCH 0/6] Support for the Kernel Virtual Machine interface (v2), Anthony Liguori, 2008/02/01
- [Qemu-devel] [PATCH 1/6] Fix VMware VGA init call, Anthony Liguori, 2008/02/01
- [Qemu-devel] [PATCH 3/6] SCI fixes (v2), Anthony Liguori, 2008/02/01
- [Qemu-devel] [PATCH 2/6] Use correct types to enable > 2G support (v2), Anthony Liguori, 2008/02/01
- [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Anthony Liguori, 2008/02/03
- [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2),
Izik Eidus <=
- [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Anthony Liguori, 2008/02/04
- [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Avi Kivity, 2008/02/10
- Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Paul Brook, 2008/02/10
- Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Avi Kivity, 2008/02/10
- Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Paul Brook, 2008/02/10
- Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Avi Kivity, 2008/02/10
[Qemu-devel] [PATCH 4/6] Fix daemonize options (v2), Anthony Liguori, 2008/02/01
[Qemu-devel] [PATCH 5/6] Tell BIOS about the number of CPUs (v2), Anthony Liguori, 2008/02/01
[Qemu-devel] [PATCH 6/6] QEMU support for the Kernel Virtual Machine interface (v2), Anthony Liguori, 2008/02/01