[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v

From: Anthony Liguori
Subject: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2)
Date: Mon, 04 Feb 2008 09:31:37 -0600
User-agent: Thunderbird (X11/20071229)

Izik Eidus wrote:
Do you recall what this change fixed? As Paul pointed out in IRC, using the host type here doesn't really fix the problem (target_ulong would be more appropriate). However, we're both curious what problem it's actually fixing since sign extending the int should just work.

ok the commit say:

   kvm: qemu: change the type of the various page masks to unsigned long
prevents truncation with >=4GB of guest physical memory

as far as i remember it was used to address something with
cpu_physical_memory_rw() probably related to &TARGET_PAGE_SIZE

the fact is that i dont know if it ever fixed anything

Thanks, that was my suspicion too.


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]