[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] avoid name clashes due to LIST_* macros

From: Johannes Schindelin
Subject: Re: [Qemu-devel] [PATCH] avoid name clashes due to LIST_* macros
Date: Thu, 7 Feb 2008 12:49:25 +0000 (GMT)
User-agent: Alpine 1.00 (LSU 882 2007-12-20)


On Thu, 7 Feb 2008, Ian Jackson wrote:

> Anthony Liguori writes ("Re: [Qemu-devel] [PATCH] avoid name clashes due to 
> LIST_* macros"):
> > Ian Jackson wrote:
> >
> > > qemu's audio subdirectory contains a copy of BSD's sys-queue.h, 
> > > which defines a bunch of LIST_ macros.  This makes it difficult to 
> > > build a program made partly out of qemu and partly out of the Linux 
> > > kernel[1], since Linux has a different set of LIST_ macros.  It 
> > > might also cause trouble when mixing with BSD-derived code.
> > 
> > That doesn't seem like a very good justification.  If you're mixing 
> > QEMU code with other code,
> Well, surely with something like qemu one might expect to mix the code 
> with other things ?

Read what you wrote.  By that reasoning you cannot use _any_ name in qemu, 
because qemu should bend over to be mixable with other code.

Now, if you seriously want to integrate the audiosubsystem with something 
in the Linux kernel, you might rename the macros.  But unless you 
contribute that code, and people like it, I guess you will not stand much 
of a chance to get the renaming patch into QEmu.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]