[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] avoid name clashes due to LIST_* macros

From: malc
Subject: Re: [Qemu-devel] [PATCH] avoid name clashes due to LIST_* macros
Date: Thu, 7 Feb 2008 22:42:55 +0300 (MSK)

On Thu, 7 Feb 2008, Ian Jackson wrote:

Johannes Schindelin writes ("Re: [Qemu-devel] [PATCH] avoid name clashes due to 
LIST_* macros"):
Read what you wrote.  By that reasoning you cannot use _any_ name in qemu,
because qemu should bend over to be mixable with other code.

No, not at all.  Just that when a clash happens something sensible
should be done: one or the other should be renamed.

A bit of history: audio/sys-qemu.h only exists because when i was working
on Windows side of things plain <sys/queue.h> wasn't available for Mingw
(maybe things changed since then) so i took the liberty of copying the
header from my linux system and using it.

It would have been interesting if <sys/queue.h> was part of Mingw because
i doubt that you would have pushed for changing the system supplied

Anyway that was just to put things into perspective.

Now, if you seriously want to integrate the audiosubsystem with something
in the Linux kernel, you might rename the macros.  But unless you
contribute that code, and people like it, I guess you will not stand much
of a chance to get the renaming patch into QEmu.

This problem is not theoretical.  I wouldn't be arguing about it
otherwise.  Without this change, our minios qemu does not build.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]