[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Better version.rc patch

From: Johannes Schindelin
Subject: Re: [Qemu-devel] [PATCH] Better version.rc patch
Date: Fri, 8 Feb 2008 20:49:23 +0000 (GMT)
User-agent: Alpine 1.00 (LSU 882 2007-12-20)


On Fri, 8 Feb 2008, C.W. Betts wrote:

> This is a better patch to make qemu on Windows show info when you go 
> into properties.

It is _still_ a hassle to review your patch, since you did not inline it 

So I will comment without quoting any of your patch, which will leave 
others guessing as to what we're talking about.

FILEVERSION and PRODUCTVERSION need to get a #define'd value, which you 
have to #define in ./configure in config-host.h, as I suggested already.

Also, it seems as you have yet another line which is commented out, with a 
comment "currently not working".  I'd appreciate it if it was left out, or 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]