[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G suppor

From: Avi Kivity
Subject: Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2)
Date: Sun, 10 Feb 2008 16:55:08 +0200
User-agent: Thunderbird (X11/20071115)

Paul Brook wrote:
as far as i remember it was used to address something with
cpu_physical_memory_rw() probably related to &TARGET_PAGE_SIZE

the fact is that i dont know if it ever fixed anything
It fixes TARGET_PAGE_MASK, defined one line downscreen.

That doesn't really answer the question. What was wrong with the original definition?

There are many instances of ((physical address) & TARGET_PAGE_MASK) scattered throughout the code. With 64-bit physical addresses, this causes truncation.

Are suggesting to fix TARGET_PAGE_MASK directly? I think fixing TARGET_PAGE_SIZE is better as everything else is defined in terms of it.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]