qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [4164] MIPS Magnum R4000 machine


From: Aurelien Jarno
Subject: Re: [Qemu-devel] [4164] MIPS Magnum R4000 machine
Date: Tue, 08 Apr 2008 10:01:39 +0200
User-agent: IceDove 1.5.0.14pre (X11/20080208)

Hervé Poussineau a écrit :
> Aurelien Jarno a écrit :
>> Revision: 4164
>>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4164
>> Author:   aurel32
>> Date:     2008-04-07 19:47:14 +0000 (Mon, 07 Apr 2008)
>>
>> Log Message:
>> -----------
>> MIPS Magnum R4000 machine
>  >
>> Added Paths:
>> -----------
>>     trunk/hw/mips_jazz.c
>>     trunk/hw/rc4030.c
>>
> 
> Please be consistent.
> The added files are encoded in unicode, whereas existing ones are not.

Wrong they are not encoded in unicode (should be UTF-16 from your
description on IRC), but in UTF-8. It's your software which convert them
to UTF-16.

Also a few other files are *already* encoded in UTF-8 in the SVN.

> Also, diff.exe on Windows (provided with MSYS) considers unicode files 
> as binary, which means that I can't provide patches for them...

Then you software is buggy.

The only workaround I can see from the software point of view is to
remove the accents from you name in those files, so that they are
changed to plain ASCII. But in that case, please don't submit patches
with non-ASCII chars. Also I won't change other files already in UTF-8.

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net




reply via email to

[Prev in Thread] Current Thread [Next in Thread]