[Qemu-devel] Re: [RFC][PATCH 4/4] Add support for Marvell 88w8618 / MusicPal

[Jan Kiszka]

Stuart Brady wrote:
> On Mon, Apr 14, 2008 at 08:59:30AM +0200, Jan Kiszka wrote:
>> malc wrote:
>>> Zero is not correct "mute" value for signed formats.
>> Hmm, maybe it's still too early for me - but what else??
> 
> Well, zero is not correct for unsigned formats, but I cannot see any
> such formats in use in your emulation...

/me too.

> BTW, there are quite a few magic constants that it would probably be
> better to #define.

I know. Comes a bit from the initial approach: "Hey, let's see how far
this hack will get."

Will try to fix those spots where possible.

Jan

signature.asc
Description: OpenPGP digital signature