Re: [Qemu-devel] [4261] Errors while registering ioports are not fatal (Glauber Costa).

[Paul Brook]

On Saturday 26 April 2008, Anthony Liguori wrote:
> Paul Brook wrote:
> > On Saturday 26 April 2008, Andrzej Zaborowski wrote:
> >> Revision: 4261
> >>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4261
> >> Author:   balrog
> >> Date:     2008-04-26 16:04:29 +0000 (Sat, 26 Apr 2008)
> >>
> >> Log Message:
> >> -----------
> >> Errors while registering ioports are not fatal (Glauber Costa).
> >
> > Why shouldn't they be fatal? How can this be anything other than a
> > serious bug in the device emulation?
>
> I think the idea is that the device should fail to initialize rather the
> VM being destroyed.  Consider the case of PCI hotplug.  It's a
> recoverable error if register ioport fails during hot add.

The errors that get suppressed aren't the sort of thing that should ever 
happen. How exactly do you end up with an IO port that is not 1, 2 or 4 bytes 
in size? If this ever happens I want qemu do die right there and then. This 
isn't just a failure, it is an indication that something is broken beyond 
hope.

Paul