Re: [Qemu-devel] [PATCH] Fix regression against commit 4259

[andrzej zaborowski]

Hi,

On 26/04/2008, Jason Wessel <address@hidden> wrote:
> Stuart Brady found a regression based on the 4259 commit where
>  DNS via slirp to the special address does not work properly.
>
>  I verified that DNS to the default special address 10.0.2.3 does not
>  work.   When using the "special address" for DNS it must be treated as
>  a special case.  In the original 4259, I did not have a test case for
>  the loopback DNS.  The translation logic should be used in this case
>  as well as for any loopback directed requests.

Thanks for the fix, I committed it with a tiny change but I'm not sure
if the special case shouldn't be CTL_ALIAS, i.e. the condition would
be:

         else if (addr->sin_addr.s_addr == loopback_addr.s_addr ||
                  (ntohl(so->so_faddr.s_addr) & 0xff) != CTL_ALIAS)

and perhaps this shouldn't be for udp only?  Also, in
((so->so_faddr.s_addr & htonl(CTL_DNS)) == htonl(CTL_DNS)), masking
with htonl(CTL_DNS) is probably not what we want.

Regards