[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [4351] Make the paged properties of the tb-jmp-cache ha
|
From: |
Paul Brook |
|
Subject: |
Re: [Qemu-devel] [4351] Make the paged properties of the tb-jmp-cache hash function work for TARGET_PAGE_BITS ! = 12. |
|
Date: |
Tue, 6 May 2008 15:18:25 +0100 |
|
User-agent: |
KMail/1.9.9 |
> > > - return (tmp >> TB_JMP_PAGE_BITS) & TB_JMP_PAGE_MASK;
> > > + return (tmp >> (TARGET_PAGE_BITS - TB_JMP_PAGE_BITS)) &
> > > TB_JMP_PAGE_MASK; }
> >
> > I'm not sure what you're trying to achieve here, but this is definitely
> > wrong. TARGET_PAGE_BITS may be less than TB_JMP_PAGE_BITS.
>
> I didn't find any page bits under 10 in the tree.
Oops, sorry, my bad. I read TB_JMP_PAGE_BITS as TB_JMP_CACHE_BITS-1, not /2.
Paul