Re: [Qemu-devel] Patch removing spaces

[malc]

On Mon, 19 May 2008, Ian Jackson wrote:

> Balazs Attila-Mihaly \(Cd-MaN\) writes ("[Qemu-devel] Patch removing
> > spaces"): If anyone is interested: a patch which removes spaces from
> > the end of the lines. Compressed because it's rather big.
>
> Please don't apply this patch!
>
> Spaces at the ends of lines are indeed irritating and we should avoid
> them.  But going out of our way to remove them is definitely wrong -
> it's reformatting, which is nearly always wrong in Free Software.

[..snip..]

Preventive measure that makes the code look sufficiently ugly when
tabs or trailing whitespace is present. Hands almost reflectively
reach for `M-x nuke-trailing-whitespace' and `C-x h M-x untabify'

(defface font-lock-ws-face
  '((((class color) (background dark)) (:background "white"))
    (((class color) (background light)) (:background "black"))
    (t (:bold t)))
  "Font Lock mode face used to highlight unwated whitespace."
  :group 'font-lock-faces)
(setq font-lock-ws-face 'font-lock-ws-face)

(defun font-lock-mode-hook-fn ()
  (setq old-font-lock-keywords font-lock-keywords)
  (make-variable-buffer-local 'font-lock-keywords)
  (let ((elem
         (list
          (list "\\([ \t]+$\\)\\|\\(\t\\)"
                (list 0 font-lock-ws-face)))))
    (setq font-lock-keywords (append font-lock-keywords elem))))

(add-hook 'font-lock-mode-hook 'font-lock-mode-hook-fn)

--
mailto:address@hidden