|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH] New qemu-img convert -B option to preserve the COW aspect of images and/or re-base them |
Date: | Tue, 03 Jun 2008 16:28:15 -0500 |
User-agent: | Thunderbird 2.0.0.14 (X11/20080501) |
Jamie Lokier wrote:
Anthony Liguori wrote:It's sloppy. In general, using a non-portable feature for no good reason other than you can is bad practice (even if we do depend on GCC).It's 2008, the standard is called C99 for a reason.
Regardless, it's sloppy IMHO. It's a lot easier to determine the type of something by looking at the top of the block. And this is the convention for a very lot of projects Open Source projects, even the ones that heavily rely on GCC-isms like the Linux kernel.
Regards, Anthony Liguori
In 1998, we would have used C89 constructs like function prototypes, wouldn't we? :-) If you don't want to use non-portable features, may I suggest "gcc -std=c89". (Half joking, I use -Wdeclaration-after-statement myself to catch this, since it became a standard GCC feature with no option to turn it off and keep other GNU extensions. But then, I write code which is more portable than QEMU and target older architectures.) -- Jamie
[Prev in Thread] | Current Thread | [Next in Thread] |