qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] exec.c:283: warning: cast from pointer to integer of differ


From: Jan Kiszka
Subject: [Qemu-devel] exec.c:283: warning: cast from pointer to integer of different size
Date: Mon, 23 Jun 2008 08:28:37 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

Hi Paul,

trying to get rid of some of the various compiler warnings, specifically
on 64-bit hosts, I came across this:

> #if defined(CONFIG_USER_ONLY)
>         unsigned long addr;
>         size_t len = sizeof(PageDesc) * L2_SIZE;
>         /* Don't use qemu_malloc because it may recurse.  */
>         p = mmap(0, len, PROT_READ | PROT_WRITE,
>                  MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
>         *lp = p;
>         addr = h2g(p);
>         if (addr == (target_ulong)addr) {
>             page_set_flags(addr & TARGET_PAGE_MASK,
>                            TARGET_PAGE_ALIGN(addr + len),
>                            PAGE_RESERVED); 
>         }
> #else

Something is fishy here. h2g already returns target_ulong (and generates
compiler warnings at this chance), but the succeeding line seems to
assume that addr can still be larger than that. Now I wonder what this
code is actually supposed to do.

Jan



Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]