[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qcow2: improve I/O performance with cache=off
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH] qcow2: improve I/O performance with cache=off |
Date: |
Wed, 25 Jun 2008 10:59:51 +0200 |
Le mercredi 25 juin 2008 à 10:43 +0200, Kevin Wolf a écrit :
> Hi Laurent,
>
> Laurent Vivier schrieb:
> > I modify this patch according Avi comments, and I'll repost it.
> >
> > Thank you for your comments.
>
> It's certainly a good idea to add the change suggested by Avi. But don't
> you think you'd better make a second patch out of it, on top of this
> one? I feel that the patch to get_cluster_offset might not be too small
> for itself.
Yes, you're right. So I'll resend this patch in a serie.
> Oh, and while you're at it... ;-) I think this function could use at
> least some more comments, and splitting out some parts as new functions
> could also help with its readability.
I'll think about that. But adding more functions can also be bad for the
readability.
Thank you,
Laurent
--
------------- address@hidden ---------------
"The best way to predict the future is to invent it."
- Alan Kay