[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH][ARM] Fix wrong destination register for smu

From: Paul Brook
Subject: Re: [Qemu-devel] Re: [PATCH][ARM] Fix wrong destination register for smuad, smusd, smlad, smlsd
Date: Wed, 25 Jun 2008 17:58:38 +0100
User-agent: KMail/1.9.9

On Wednesday 25 June 2008, Laurent Desnogues wrote:
> 2008/6/23 Laurent Desnogues <address@hidden>:
> > smuad, smusd, smlad, smlsd write the wrong register, resulting in
> > PC corruption.
> Here is a better patch.
> I will stop posting patches as I have the feeling the maintainer
> doesn't care.  He might be rewriting everything and so my
> patches are useless and a waste of time for everyone :-)

TBH It's hard to tell if these are well tested patches, or just quick hacks 
that you're throwing over the wall.

As above where it took you two tries. This isn't bad per se, but compete lack 
of explanation about what's different doesn't help. Some of your other 
patches have been prefixed with "I did not check the correctness of that 
instruction in general, I only made a change that looked logical" and "These 
are all *wild guesses*". As we know from the recent Debian SSL debacle 
making "a change that looked logical" can be fairly disastrous :-)

This means I'm unwilling to accept the patches a face value, and need to go 
through them with a fine tooth comb. This takes time, and you go in the queue 
with the dozens of other of patches, bugs and new features that need my 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]