[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [4799] Add instruction counter.
From: |
J. Mayer |
Subject: |
Re: [Qemu-devel] [4799] Add instruction counter. |
Date: |
Sun, 29 Jun 2008 13:57:15 +0200 |
On Sun, 2008-06-29 at 11:58 +0200, Laurent Desnogues wrote:
> On Sun, Jun 29, 2008 at 3:03 AM, Paul Brook <address@hidden> wrote:
> > Revision: 4799
> > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4799
> > Author: pbrook
> > Date: 2008-06-29 01:03:05 +0000 (Sun, 29 Jun 2008)
>
> Some trivial comments:
> - missing gen_icount.h file
> - duplicate num_insns = 0; in
> target_mips/translate.c/gen_intermediate_code_internal
> - typo in vl.c/help "clock ticks per instructon"
> - typo in qemu-doc.texi under icount: "cache heirachies"
A few more comments, taking a quick look at the PowerPC target changes:
+void ppc_translate_init(void)
+{
+ int done_init = 0;
+ if (done_init)
+ return;
+ cpu_env = tcg_global_reg_new(TCG_TYPE_PTR, TCG_AREG0, "env");
+ done_init = 1;
+}
- done_init is on the stack, thus will never be 1.
- why isn't this variable / code shared with other targets (can see the
exact same code in Alpha target...) ?
- one detail: this function is more likely to be found in
translate_init.c
--
J. Mayer <address@hidden>
Never organized
Re: [Qemu-devel] [4799] Add instruction counter., C.W. Betts, 2008/06/29