[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/3] Do not call fcntl(, O_NONBLOCK) pointlessly.
From: |
Ian Jackson |
Subject: |
[Qemu-devel] [PATCH 1/3] Do not call fcntl(, O_NONBLOCK) pointlessly. |
Date: |
Fri, 18 Jul 2008 14:15:01 +0100 |
It is silly to call fcntl(fd,F_SETFL,O_NONBLOCK) immediately after
opening the fd in nonblocking mode.
Signed-off-by: Ian Jackson <address@hidden>
---
vl.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/vl.c b/vl.c
index 81f7d8f..4f31288 100644
--- a/vl.c
+++ b/vl.c
@@ -2435,7 +2435,6 @@ static CharDriverState *qemu_chr_open_tty(const char
*filename)
int fd;
TFR(fd = open(filename, O_RDWR | O_NONBLOCK));
- fcntl(fd, F_SETFL, O_NONBLOCK);
tty_serial_init(fd, 115200, 'N', 8, 1);
chr = qemu_chr_open_fd(fd, fd);
if (!chr) {
--
1.4.4.4
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH 1/3] Do not call fcntl(, O_NONBLOCK) pointlessly.,
Ian Jackson <=