|
From: | Andreas Färber |
Subject: | Re: [Qemu-devel] [PATCH 1/3] Fix SDL problems with BGR displays |
Date: | Tue, 22 Jul 2008 23:25:50 +0200 |
Hi, Am 22.07.2008 um 22:51 schrieb Anthony Liguori:
From: Avi Kivity <address@hidden> kvm: qemu: revert qemu's sdl.c rev 1.40 this fixes problems with bgr displays.
What problems exactly are you fixing? Could other backends such as Cocoa be affected, too?
Signed-off-by: Avi Kivity <address@hidden> Signed-off-by: Anthony Liguori <address@hidden> diff --git a/sdl.c b/sdl.c index bac60ea..719e2bd 100644 --- a/sdl.c +++ b/sdl.c@@ -89,7 +89,7 @@ static void sdl_resize(DisplayState *ds, int w, int h)ds->data = screen->pixels; ds->linesize = screen->pitch; ds->depth = screen->format->BitsPerPixel; - if (screen->format->Bshift > screen->format->Rshift) { + if (ds->depth == 32 && screen->format->Rshift == 0) { ds->bgr = 1; } else { ds->bgr = 0;
Why does BGR depend on a depth of 32? Andreas
[Prev in Thread] | Current Thread | [Next in Thread] |