[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmis

From: Laurent Vivier
Subject: Re: [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmissing-prototypes
Date: Mon, 11 Aug 2008 20:57:01 +0200

Le 11 août 08 à 20:52, Blue Swirl a écrit :

On 8/11/08, Anthony Liguori <address@hidden> wrote:
Avi Kivity wrote:

You lose the switch(nb_args) in monitor_handle_command() so it comes out
even. You don't need to cast anything -- though you do need to change all
the callbacks to accept an argument array.

And to either explicitly cast each argument or explicitly parse each
argument.  It touches quite a bit of places in the code and makes the
callbacks quite a bit more complicated.

Using a void * is a one line change and works on all modern systems. Seems
like a winner to me :-)

I vote for this. The other solutions do not improve type safety
(except for union) and they are more complex.

But I think to call the function you have to cast the pointer, this doesn't improve type safety too...

----------------------- Laurent Vivier ----------------------
"The best way to predict the future is to invent it."
- Alan Kay

reply via email to

[Prev in Thread] Current Thread [Next in Thread]