[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/8] husb: Fixup printfs and stuff based on the revi
From: |
Max Krasnyansky |
Subject: |
[Qemu-devel] [PATCH 7/8] husb: Fixup printfs and stuff based on the review comments |
Date: |
Fri, 15 Aug 2008 00:51:49 +0000 |
Addressing Anthony's comments regarding printf and stuff.
Anthony, if you you want I can fold this commit and resend
the original patch.
Signed-off-by: Max Krasnyansky <address@hidden>
---
usb-linux.c | 11 ++++-------
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/usb-linux.c b/usb-linux.c
index dd78bb6..c31d56a 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -272,7 +272,7 @@ static int usb_host_update_interfaces(USBHostDevice *dev,
int configuration)
}
if (i >= dev->descr_len) {
- printf("husb: update iface failed. no matching configuration\n");
+ fprintf(stderr, "husb: update iface failed. no matching
configuration\n");
goto fail;
}
nb_interfaces = dev->descr[i + 4];
@@ -815,9 +815,6 @@ static int usb_host_auto_scan(void *opaque, int bus_num,
int addr,
return 0;
for (f = usb_auto_filter; f; f = f->next) {
- // printf("Auto match: bus_num %d addr %d vid %d pid %d\n",
- // bus_num, addr, vendor_id, product_id);
-
if (f->bus_num >= 0 && f->bus_num != bus_num)
continue;
@@ -860,8 +857,8 @@ static void usb_host_auto_add(int bus_num, int addr, int
vendor_id, int product_
{
struct USBAutoFilter *f = qemu_mallocz(sizeof(*f));
if (!f) {
- printf("husb: failed to allocate auto filter\n");
- return;
+ fprintf(stderr, "husb: failed to allocate auto filter\n");
+ return;
}
f->bus_num = bus_num;
@@ -878,7 +875,7 @@ static void usb_host_auto_add(int bus_num, int addr, int
vendor_id, int product_
*/
usb_auto_timer = qemu_new_timer(rt_clock, usb_host_auto_timer, NULL);
if (!usb_auto_timer) {
- printf("husb: failed to allocate timer\n");
+ fprintf(stderr, "husb: failed to allocate auto scan timer\n");
qemu_free(f);
return;
}
--
1.5.5.1
- [Qemu-devel] [PATCH 0/8] Various USB fixes and improvements (update 2), Max Krasnyansky, 2008/08/14
- [Qemu-devel] [PATCH 1/8] husb: support for USB host device auto disconnect., Max Krasnyansky, 2008/08/14
- [Qemu-devel] [PATCH 2/8] husb: support for USB host device auto connect., Max Krasnyansky, 2008/08/14
- [Qemu-devel] [PATCH 3/8] usb: generic packet handler cleanup and documentation, Max Krasnyansky, 2008/08/14
- [Qemu-devel] [PATCH 5/8] husb: rewrite Linux host USB layer, fully async operation, Max Krasnyansky, 2008/08/14
- [Qemu-devel] [PATCH 4/8] uhci: rewrite UHCI emulator, fully async operation with multiple outstanding transactions, Max Krasnyansky, 2008/08/14
- [Qemu-devel] [PATCH 7/8] husb: Fixup printfs and stuff based on the review comments,
Max Krasnyansky <=
- [Qemu-devel] [PATCH 8/8] uhci: fixes for save/load-vm, Max Krasnyansky, 2008/08/14
- [Qemu-devel] [PATCH 6/8] husb: remove disconnect detection timer, Max Krasnyansky, 2008/08/14
- [Qemu-devel] Re: [PATCH 0/8] Various USB fixes and improvements (update 2), Anthony Liguori, 2008/08/18
- [Qemu-devel] Re: [PATCH 0/8] Various USB fixes and improvements (update 2), Anthony Liguori, 2008/08/21