Re: [Qemu-devel] pty/tty functions for BSD too

[Blue Swirl]

On 8/18/08, Samuel Thibault <address@hidden> wrote:
> Anthony Liguori, le Mon 18 Aug 2008 09:06:41 -0500, a écrit :
>
> > Samuel Thibault wrote:
>  > >In Xen, pty/tty functions are enabled for BSD too, shouldn't we enable
>  > >them in upstream qemu too, as patched below?
>  > >
>  >
>  > And you're sure that these functions compile/work on NetBSD/OpenBSD?
>
>
> The defines are explicit in Xen, so I guess somebody tested it.  I
>  haven't myself.  I wonder why there is no FreeBSD however.

The patch does not work on OpenBSD, because while openpty() is
available, ptsname() isn't.

I tested the attached version on OpenBSD and Linux, pty name is
printed correctly.

obsd_enable_pty_code.diff
Description: plain/text