[Qemu-devel] Re: [5055] Handle terminating signals (Gerd Hoffmann)

[Jan Kiszka]

Gerd Hoffmann wrote:
>>>> --- a/vl.c
>>>> +++ b/vl.c
>>>> @@ -7624,8 +7624,10 @@ static int main_loop(void)
>>>>                  timeout = 0;
>>>>              }
>>>>          } else {
>>>> -            if (shutdown_requested)
>>>> +            if (shutdown_requested) {
>>>> +                ret = EXCP_INTERRUPT;
>>>>                  break;
>>>> +            }
>>> Fix looks fine to me.
>> So we don't need to bother about no_shutdown in this path?
> 
> I don't think so.  The no_shutdown makes qemu stop the vm instead of
> exiting instantly, probably to allow analyzing the situation in case of
> a guest-triggered shutdown.  There is no point in doing so in case the
> vm already is in stopped state.

OK, makes sense.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux