Re: [Qemu-devel] [PATCH 1/1] Make vmport an optional feature at run time.

[Ian Kirk]

Thiemo Seufer wrote:

> Anthony Liguori wrote:
> > Ian Kirk wrote:
> >> Anthony Liguori wrote:
> >>
> >>
> >>> Ian Kirk wrote:
> >>>
> >>>> Hi,
> >>>>
> >>>> This is my first time sending a patch, so apologies for any errors.
> >>>>
> >>>> Patch makes vmport optionally initiated.
> >>>>
> >>>>
> >>> Why should it be optional?
> >>>
> >>
> >> I believe that VMware ESXi (and perhaps other hypervisors/emulators/etc)
> >> doesn't work when it thinks it is running within virtual enviroment, as it
> >> talks to vmport when booting (and fails in the current implemtnation -
> >> perhaps it only works under itself?)
> >>
> >
> > That's most likely because the vmport emulation isn't complete enough.
> >
> >> If I comment init_vmport() out, it definately progresses further along the
> >> boot sequence.
> >>
> >> Also, I guess, it gives you the option to better emulate a real PC (which
> >> I assume doesn't have vmport).
> >>
> >
> > I don't think that's very valuable in and of itself.  Moreover, there
> > are probably a lot more issues with respect to getting ESXi to run under
> > QEMU.  Adding another command line option to support something that we
> > don't know will ever work worries me.  It's just another knob for
> > someone to accidentally tweak.
>
> At this point I wonder if we should have both a "real PC" machine and
> a "virtual x86" machine. We have already seen patches for a xen-specific
> variant of the latter.

I guess this was what I wanted - for QEMU to (more) emulate a real PC
(real PCs don't have vmport?).

If there is a better or more elegant way of doing it ...