qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation.


From: Ian Jackson
Subject: Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation.
Date: Tue, 26 Aug 2008 12:02:45 +0100

Gerd Hoffmann writes ("[Qemu-devel] [PATCH 1/2] xenner: add event channel 
implementation."):
> The patch also adds a XenEvtOps struct with function pointers for the
> xc_evtchn_* family, which is used to switch between libxenctrl and the
> qemu implementation at runtime.  By default libxenctrl is used.

I don't understand why it's necessary to switch between these two
modes at runtime.  That adds a lot of extra boilerplate and
indirection code and probably has some tiny performance effect too.

Why not make it a compile-time option ?

Even if the xen qemu becomes nearly identical to upstream, version
skew issues with the hypervisor, dom0 kernel, and so on will mean that
there will have to be a separate qemu branch for xen just for release
management purposes and so on.

Ian.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]