[Qemu-devel] Re: [PATCH] usb: Support for removing device by host addr, improved auto filter syntax

[Max Krasnyansky]

Anthony Liguori wrote:
> Max Krasnyansky wrote:
>> This patch adds support for removing USB devices by host address.
>> Which is usefull for things like libvirtd because there is no easy way to
>> find guest USB address of the host device.
>> In other words you can now do:
>>    usb_add host:3.5
>>    ...
>>    usb_del host:3.5
>> Before the patch 'usb_del' did not support 'host:' notation.
>>
>>   
> 
> This patch breaks the windows build with:
> 
> i686-pc-mingw32-gcc -Wall -O2 -g -fno-strict-aliasing  -m32 -I.
> -I/home/anthony/svn/qemu -MMD -MP -MT usb-linux.o -D_GNU_SOURCE
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
> -I/home/anthony/svn/qemu/slirp -c -o usb-linux.o
> /home/anthony/svn/qemu/usb-linux.c
> /home/anthony/svn/qemu/usb-linux.c:1205: error: conflicting types for
> 'usb_host_device_close'
> /home/anthony/svn/qemu/hw/usb.h:243: error: previous declaration of
> 'usb_host_device_close' was here
> make: *** [usb-linux.o] Error 1

I'll take a look and resend. Thanx for testing.

Max