Re: [Qemu-devel] [PATCH] scsi-generic: correct usage of memset().

[Anthony Liguori]

Laurent Vivier wrote:
>       void *memset(void *s, int c, size_t n);
>
> DESCRIPTION
>        The  memset()  function  fills  the  first  n  bytes of the
> memory area
>        pointed to by s with the constant byte c."
>
> Reported by Dietmar Maurer.
>   

Applied.  Thanks.

Regards,

Anthony Liguori

> Signed-off-by: Laurent Vivier <address@hidden>
> ---
>  hw/scsi-generic.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: qemu/hw/scsi-generic.c
> ===================================================================
> --- qemu.orig/hw/scsi-generic.c 2008-09-22 10:46:42.000000000 +0200
> +++ qemu/hw/scsi-generic.c      2008-09-22 14:32:26.000000000 +0200
> @@ -548,8 +548,8 @@ static int get_blocksize(BlockDriverStat
>      sg_io_hdr_t io_header;
>      int ret;
>  
> -    memset(cmd, sizeof(cmd), 0);
> -    memset(buf, sizeof(buf), 0);
> +    memset(cmd, 0, sizeof(cmd));
> +    memset(buf, 0, sizeof(buf));
>      cmd[0] = READ_CAPACITY;
>  
>      memset(&io_header, 0, sizeof(io_header));
>
>
>
>