[Qemu-devel] Re: [Patch] Segfault with -vnc option

[Anthony Liguori]

Jan Niehusmann wrote:
> Hi!
>   

Hi Jan,

Very good catch.  My only suggestion would be to move this check into 
cirrus_vga.c and vmware_vga.c.  Even better would be to introduce a 
wrapper around callers of dpy_copy.

Regards,

Anthony Liguori

> Signed-off-by: Jan Niehusmann <address@hidden>
>
> --- qemu/vnc.c.orig     2008-09-22 18:38:08.000000000 +0200
> +++ qemu/vnc.c  2008-09-22 18:39:13.000000000 +0200
> @@ -457,6 +457,9 @@
>      int pitch = ds->linesize;
>      VncState *vs = ds->opaque;
>  
> +    /* Skip copy when on text console */
> +    if(!is_graphic_console()) return;
> +
>      vnc_update_client(vs);
>  
>      if (dst_y > src_y) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to address@hidden
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>