[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] preprocessor issue in qemu/patch-block-raw-posi
From: |
Juergen Lock |
Subject: |
Re: [Qemu-devel] [PATCH] preprocessor issue in qemu/patch-block-raw-posix.c |
Date: |
Fri, 26 Sep 2008 23:29:25 +0200 |
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Thu, Sep 25, 2008 at 03:39:58PM -0500, Anthony Liguori wrote:
> Juergen Lock wrote:
>> I forgot to note that this also needed the following patch:
>>
>
> Why? This #ifdef is working around a very specific bug.
>
Well, looks like the preprocessor tries to parse the entire expression
including the undefined `!__GLIBC_PREREQ(2, 4)' before evaluating it:
block-raw-posix.c:548:69: missing binary operator before token "("
so I just put it on an extra line.
> Regards,
>
> Anthony Liguori
>
>> Index: qemu/block-raw-posix.c
>> @@ -545,7 +545,8 @@
>> qemu_aio_set_fd_handler(s->fd, posix_aio_read, NULL,
>> posix_aio_flush, s);
>> -#if defined(__linux__) && defined(__GLIBC_PREREQ) && !__GLIBC_PREREQ(2,
>> 4)
>> +#if defined(__linux__) && defined(__GLIBC_PREREQ)
>> +#if !__GLIBC_PREREQ(2, 4)
>> {
>> /* XXX: aio thread exit seems to hang on RedHat 9 and this init
>> seems to fix the problem. */
>> @@ -557,6 +558,7 @@
>> aio_init(&ai);
>> }
>> #endif
>> +#endif
>> posix_aio_state = s;
>> return 0;
>>
>> Signed-off-by: Juergen Lock <address@hidden>
>>
>>
>>
>
- Re: [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5313), (continued)
- Re: [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5313), Juergen Lock, 2008/09/27
- Re: [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5313), Anthony Liguori, 2008/09/30
- Re: [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5313), Juergen Lock, 2008/09/30
- Re: [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5331), Juergen Lock, 2008/09/27
- Re: [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5331), Carlos A. M. dos Santos, 2008/09/28
- Re: [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5331), Juergen Lock, 2008/09/30
- Re: [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5331), Anthony Liguori, 2008/09/30
- Re: [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5331), Juergen Lock, 2008/09/30
- [Qemu-devel] [PATCH] preprocessor issue in qemu/patch-block-raw-posix.c (was: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5313)), Juergen Lock, 2008/09/25
- Re: [Qemu-devel] [PATCH] preprocessor issue in qemu/patch-block-raw-posix.c, Anthony Liguori, 2008/09/25
- Re: [Qemu-devel] [PATCH] preprocessor issue in qemu/patch-block-raw-posix.c,
Juergen Lock <=
- Re: [Qemu-devel] [PATCH] preprocessor issue in qemu/patch-block-raw-posix.c, Anthony Liguori, 2008/09/27