[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch] Introduce per machine based max_cpu variable
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [patch] Introduce per machine based max_cpu variable |
Date: |
Thu, 2 Oct 2008 16:45:34 +0100 |
User-agent: |
KMail/1.9.9 |
> Here's an attempt of implementing a per-machine max_cpus variable.
> This means developers can limit smp support to match the actual board
> sizes. It also makes the static MAX_CPUS check in vl.c obsolete which
> I think is a good thing :-)
This looks reasonable, but is still not an ideal solution. It is an
improvement over what we currently have, so I'm not going to object to it
being applied.
The maximum number of CPUs may be a property of the CPU, not the board.
Especially in the embedded world it's becoming common to have multicore CPUs
connected to dumb single socket systems/boards.
IMHO max_cpus should be the actual number of cpus, not N-1 as has been
suggested elsewhere in this thread. It may be ok to accept max_cpus==0 as a
special case meaning max_cpus==1 to avoid having to change all the machine
descriptions. Probably less confusing to just make all the changes you
suggested though.
Paul