Re: [Qemu-devel] [PATCH] ARM CP14 trivial support

[Paul Brook]

On Monday 13 October 2008, Daniel Silverstone wrote:
> Hi,
>
> Continuing the patch series aiming at supporting Simtec's development
> boards and other Samsung SoC based systems, attached is a patch which
> provides trivial coprocessor 14 support.

I dislike code that blindly ignores everything. Functions should be explicitly 
not implemented (with comments saying exactly what we're not implementing), 
or fail loudly when used. 

The cp14 interface is also used for other debug monitor hardware (breakpoints, 
watchpoints, etc.) and possibly Jazelle DBX. Ignoring those commands is bad.  
IIRC cp14 interfaces are device specific (at least before ARMv6), so you need 
to figure out which cores your hacks apply to. There are definitely several 
different DDC interfaces.

Paul