[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] MIPS: call XREFILL handler when required
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] MIPS: call XREFILL handler when required |
Date: |
Tue, 14 Oct 2008 10:53:07 +0200 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Mon, Oct 06, 2008 at 10:51:07PM +0200, Hervé Poussineau wrote:
> Hi,
>
> In TLB Load and TLB Store exceptions, we should look at the Status
> register to know in which mode we are.
> Existing code checks upper bits of the address, which is totally wrong.
>
You are wrong. The current code is correct.
If you look at the "MIPS64 Privileged Resource Architecture document",
table "4.5 Access Control as a Function of Address and Operating Mode"
(page 17 in my edition), you will see that the refill vector actually
depends on the address and not on the current mode.
That's why your patch doesn't allow a 64-bit linux kernel to boot.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' address@hidden | address@hidden
`- people.debian.org/~aurel32 | www.aurel32.net