[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] MIPS: DMA support for RC4030 chipset
|
From: |
Blue Swirl |
|
Subject: |
Re: [Qemu-devel] [PATCH] MIPS: DMA support for RC4030 chipset |
|
Date: |
Mon, 20 Oct 2008 20:50:18 +0300 |
On 10/19/08, Hervé Poussineau <address@hidden> wrote:
> Hi,
>
> Attached patch implements DMA support to RC4030 chipset and simplifies jazz
> IO part (at 0xf0000000), where registers contain 16 bit values.
> The patch also wires DMA for the SCSI adapter in the Jazz emulation (Mips
> Magnum 4000 and Acer Pica 61).
I'd move espdma_memory_read & write to rc4030.c, that way the opaque
passed to esp_init could be directly rc4030State type.
Allocating a new dma_table every time the table changes seems
wasteful, you could read the entry from memory as needed.