Re: [Qemu-devel] [PATCH] fix bad memcpy length

[Erik de Castro Lopo]

Bruce Rogers wrote:

> --- a/qemu/trunk/hw/bt-sdp.c
> +++ b/qemu/trunk/hw/bt-sdp.c
> @@ -254,7 +254,7 @@
>      /* Perform the search */
>      if (len < 7)
>          return -SDP_INVALID_SYNTAX;
> -    memcpy(&handle, req, 6);
> +    memcpy(&handle, req, 4);

Changing one magic number to another doesn't make much sense.
Why not this instead:

    memcpy(&handle, req, sizeof (handle));

Erik
-- 
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
"life is too long to know C++ well" -- Erik Naggum