qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [5524] Fix windows build after migration changes


From: Anthony Liguori
Subject: Re: [Qemu-devel] [5524] Fix windows build after migration changes
Date: Fri, 24 Oct 2008 11:49:25 -0500
User-agent: Thunderbird 2.0.0.17 (X11/20080925)

Paul Brook wrote:
On Friday 24 October 2008, Anthony Liguori wrote:
Robert Riebisch wrote:
Anthony Liguori wrote:
That would be great.  I don't know that we want to go on the current
directory though.  There's a Windows API for finding Program Files.
That's probably what we want to do.
Why do you want to look for "Program Files" instead? Just let QEMU
determine its own folder via GetModuleFileName() and look there for the
BIOS files.
That's not the same as CWD and is probably the right thing to do.

We could also do the same thing for Linux et al.

On Linux, I guess we could readlink(/proc/self/exe), but I don't know what we could do on other OSes. In general, argv[0] isn't very useful.

What I had suggested to someone a while back, was that first, we should refactor things so that we can try to read all of the bios/keymap files from a number of paths. That way, we could try the current path, the -L path, the path of the exe, etc. The only problem with that it can become confusing trying to figure out what bios you are using.

Regards,

Anthony Liguori

Paul





reply via email to

[Prev in Thread] Current Thread [Next in Thread]