[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] Implement "info chardev" command.
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] Implement "info chardev" command. |
Date: |
Tue, 28 Oct 2008 19:08:42 +0200 |
On 10/28/08, Gerd Hoffmann <address@hidden> wrote:
> This patch makes qemu keep track of the character devices in use and
> implements a "info chardev" monitor command to print a list.
>
> qemu_chr_open() sticks the devices into a linked list now. It got a new
> argument (label), so there is a name for each device. It also assigns a
> filename to each character device. By default it just copyes the
> filename passed in. Individual drivers can fill in something else
> though. qemu_chr_open_pty() sets the filename to name of the pseudo tty
> allocated.
>
> Output looks like this:
>
> (qemu) info chardev
> monitor: filename=unix:/tmp/run.sh-26827/monitor,server,nowait
> serial0: filename=unix:/tmp/run.sh-26827/console,server
> serial1: filename=pty:/dev/pts/5
> parallel0: filename=vc:640x480
Nice!
> @@ -55,9 +56,12 @@ struct CharDriverState {
> void *opaque;
> int focus;
> QEMUBH *bh;
> + char *label;
> + char *filename;
I think you should add 'const' to both above.
[Qemu-devel] [PATCH 4/4] sockets: switch over tcp/telnet/unix serial line to new helper functions., Gerd Hoffmann, 2008/10/28
[Qemu-devel] [PATCH 2/4] sockets: helper functions for qemu., Gerd Hoffmann, 2008/10/28