qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Build breakage on OpenSolaris: --warn-common


From: Andreas Färber
Subject: Re: [Qemu-devel] Build breakage on OpenSolaris: --warn-common
Date: Sat, 1 Nov 2008 15:43:20 +0100


Am 01.11.2008 um 15:03 schrieb Blue Swirl:

On 11/1/08, Andreas Färber <address@hidden> wrote:

Am 31.10.2008 um 22:27 schrieb Blue Swirl:


On 10/31/08, Andreas Färber <address@hidden> wrote:

The following addition to configure at r5241 causes linking to fail on
OpenSolaris/amd64:

if ld --version 2>/dev/null | grep -q "GNU ld" ; then
LDFLAGS="$LDFLAGS -Wl,--warn-common"
fi

Contrary to Solaris 10, OpenSolaris does use GNU ld. Might --warn- common require an ld version newer than 2.15, or is this platform- dependent?


According to binutils changelog, --warn-common was added in 1993, so
maybe the platform breaks that. What does your ld print with ld
--version?


GNU ld version 2.15
Copyright 2002 Free Software Foundation, Inc.
This program is free software; [...]

So definitely past 1993. Any thoughts what to check for?




Previously I had also reported that Solaris 10's grep rejects -q. Could
we
use `grep "GNU ld" >/dev/null 2>/dev/null` instead?


Sure.


I'll prepare a patch for that part then.

Does this one work?
<fix_solaris_warn_common.diff>

It does on OpenSolaris, thanks. Easier than I thought. Please commit.

Andreas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]