[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tosa: basic lcd support
From: |
Dmitry Baryshkov |
Subject: |
Re: [Qemu-devel] [PATCH] tosa: basic lcd support |
Date: |
Sun, 2 Nov 2008 20:19:12 +0300 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sun, Nov 02, 2008 at 05:09:04PM +0100, andrzej zaborowski wrote:
> 2008/11/2 Dmitry Baryshkov <address@hidden>:
> > +static void tosa_tg_init(struct pxa2xx_state_s *cpu)
> > +{
> > + struct i2c_bus *bus = pxa2xx_i2c_bus(cpu->i2c[0]);
> > + struct i2c_slave *dac = i2c_slave_init(bus, 0, sizeof(struct
> > tosa_dac_i2c));
> > + dac->send = tosa_dac_send;
> > + dac->event = tosa_dac_event;
>
> You should set also .recv to not leave the kernel a possibility to
> crash qemu. Other than this, looks okay, but does this code help
> emulation in anyway? I suppose the kernel wants to see some i2c
> device present?
The kernel expects to have the DAC in place. Otherwise I see barfs from
it. So adding such simple i2c client is just a matter of preference.
Anyway, please check this patch with .recv callback set:
>From 411faec51ff4a355eb5d02eecd5936bb0bcc0dc0 Mon Sep 17 00:00:00 2001
From: Dmitry Baryshkov <address@hidden>
Date: Sat, 13 Sep 2008 13:24:23 +0400
Subject: [PATCH] tosa: basic lcd support
Signed-off-by: Dmitry Baryshkov <address@hidden>
---
hw/tosa.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 83 insertions(+), 0 deletions(-)
diff --git a/hw/tosa.c b/hw/tosa.c
index e629044..5cd3efb 100644
--- a/hw/tosa.c
+++ b/hw/tosa.c
@@ -17,6 +17,7 @@
#include "pcmcia.h"
#include "block.h"
#include "boards.h"
+#include "i2c.h"
#define TOSA_RAM 0x04000000
#define TOSA_ROM 0x00800000
@@ -38,6 +39,11 @@
#define TOSA_GPIO_CHRG_ERR_LED (TOSA_SCOOP_JC_GPIO_BASE + 2)
#define TOSA_GPIO_WLAN_LED (TOSA_SCOOP_JC_GPIO_BASE + 7)
+#define DAC_BASE 0x4e
+#define DAC_CH1 0
+#define DAC_CH2 1
+
+
static void tosa_microdrive_attach(struct pxa2xx_state_s *cpu)
{
struct pcmcia_card_s *md;
@@ -104,6 +110,81 @@ static void tosa_gpio_setup(struct pxa2xx_state_s *cpu,
scoop_gpio_out_set(scp1, TOSA_GPIO_WLAN_LED, outsignals[3]);
}
+static uint32_t tosa_ssp_read(void *opaque) {
+ return 0;
+}
+
+static void tosa_ssp_write(void *opaque, uint32_t value)
+{
+ fprintf(stderr, "TG: %d %02x\n", value >> 5, value & 0x1f);
+}
+
+struct tosa_dac_i2c {
+ i2c_slave i2c;
+ int len;
+ char buf[3];
+};
+
+static int tosa_dac_send(i2c_slave *i2c, uint8_t data)
+{
+ struct tosa_dac_i2c *s = (struct tosa_dac_i2c *)i2c;
+ s->buf[s->len] = data;
+ if (s->len ++ > 2) {
+#ifdef VERBOSE
+ fprintf(stderr, "%s: message too long (%i bytes)\n", __FUNCTION__,
s->len);
+#endif
+ return 1;
+ }
+
+ if (s->len == 2) {
+ fprintf(stderr, "dac: channel %d value 0x%02x\n",
+ s->buf[0], s->buf[1]);
+ }
+
+ return 0;
+}
+
+static void tosa_dac_event(i2c_slave *i2c, enum i2c_event event)
+{
+ struct tosa_dac_i2c *s = (struct tosa_dac_i2c *)i2c;
+ s->len = 0;
+ switch (event) {
+ case I2C_START_SEND:
+ break;
+ case I2C_START_RECV:
+ printf("%s: recv not supported!!!\n", __FUNCTION__);
+ break;
+ case I2C_FINISH:
+#ifdef VERBOSE
+ if (s->len < 2)
+ printf("%s: message too short (%i bytes)\n", __FUNCTION__, s->len);
+ if (s->len > 2)
+ printf("%s: message too long\n", __FUNCTION__);
+#endif
+ break;
+ default:
+ break;
+ }
+}
+
+int tosa_dac_recv(i2c_slave *s) {
+ printf("%s: recv not supported!!!\n", __FUNCTION__);
+ return -1;
+}
+
+static void tosa_tg_init(struct pxa2xx_state_s *cpu)
+{
+ struct i2c_bus *bus = pxa2xx_i2c_bus(cpu->i2c[0]);
+ struct i2c_slave *dac = i2c_slave_init(bus, 0, sizeof(struct
tosa_dac_i2c));
+ dac->send = tosa_dac_send;
+ dac->event = tosa_dac_event;
+ dac->recv = tosa_dac_recv;
+ i2c_set_slave_address(dac, DAC_BASE);
+ pxa2xx_ssp_attach(cpu->ssp[1], tosa_ssp_read,
+ tosa_ssp_write, cpu);
+}
+
+
static struct arm_boot_info tosa_binfo = {
.loader_start = PXA2XX_SDRAM_BASE,
.ram_size = 0x04000000,
@@ -140,6 +221,8 @@ static void tosa_init(ram_addr_t ram_size, int vga_ram_size,
tosa_microdrive_attach(cpu);
+ tosa_tg_init(cpu);
+
/* Setup initial (reset) machine state */
cpu->env->regs[15] = tosa_binfo.loader_start;
--
1.5.6.5
--
With best wishes
Dmitry
- [Qemu-devel] [PATCH] tosa: basic lcd support, (continued)
- [Qemu-devel] [PATCH] tosa: basic lcd support, Dmitry Baryshkov, 2008/11/02
- [Qemu-devel] [PATCH] tosa: provide correct IRQ to tc6393xb init, Dmitry Baryshkov, 2008/11/02
- [Qemu-devel] [PATCH] tosa: disable pxafb as it's not used on tosa., Dmitry Baryshkov, 2008/11/02
- [Qemu-devel] [PATCH] tc6393xb: non-accelerated FB support, Dmitry Baryshkov, 2008/11/02
- Re: [Qemu-devel] [PATCH] tc6393xb: non-accelerated FB support, andrzej zaborowski, 2008/11/02
- Re: [Qemu-devel] [PATCH] tc6393xb: non-accelerated FB support, Dmitry Baryshkov, 2008/11/02
- Re: [Qemu-devel] [PATCH] tc6393xb: non-accelerated FB support, Dmitry Baryshkov, 2008/11/02
- Re: [Qemu-devel] [PATCH] tc6393xb: non-accelerated FB support, andrzej zaborowski, 2008/11/03
- Re: [Qemu-devel] [PATCH] tc6393xb: non-accelerated FB support, Dmitry, 2008/11/03
- Re: [Qemu-devel] [PATCH] tosa: basic lcd support, andrzej zaborowski, 2008/11/02
- Re: [Qemu-devel] [PATCH] tosa: basic lcd support,
Dmitry Baryshkov <=
- Re: [Qemu-devel] [PATCH] tosa: basic lcd support, andrzej zaborowski, 2008/11/04
[Qemu-devel] Re: [PATCH] scoop: GPRR reports the state of GPIO lines, Dmitry Baryshkov, 2008/11/02