[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] Fix alarm_timer race with select
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] Re: [PATCH] Fix alarm_timer race with select |
|
Date: |
Wed, 05 Nov 2008 14:01:49 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Jamie Lokier wrote:
> Jan Kiszka wrote:
>> + if (pipe(fds) || fcntl(fds[0], F_SETFL, O_NONBLOCK)
>> + || fcntl(fds[1], F_SETFL, O_NONBLOCK)) {
>
> Is this a portable way to set O_NONBLOCK on all host platforms?
> I'm under the impression you need to ues F_GETFL first, in case
> other flags are important to the functioning of the file descriptor.
[ Checking the spec ] That's likely true, read-modify-write is
recommended. Can changes this. Consequently, quite a few other spots in
qemu should then be changed as well...
Jan
signature.asc
Description: OpenPGP digital signature