Re: [Qemu-devel] [PATCH] Define OS-dependent qemu_getpagesize()

[Anthony Liguori]

Hollis Blanchard wrote:
> Signed-off-by: Hollis Blanchard <address@hidden>
>   

This breaks the -linux-user build.

> diff --git a/qemu/exec.c b/qemu/exec.c
> --- a/qemu/exec.c
> +++ b/qemu/exec.c
> @@ -239,16 +239,7 @@ static void page_init(void)
>  {
>      /* NOTE: we can always suppose that qemu_host_page_size >=
>         TARGET_PAGE_SIZE */
> -#ifdef _WIN32
> -    {
> -        SYSTEM_INFO system_info;
> -
> -        GetSystemInfo(&system_info);
> -        qemu_real_host_page_size = system_info.dwPageSize;
> -    }
> -#else
> -    qemu_real_host_page_size = getpagesize();
> -#endif
> +    qemu_real_host_page_size = qemu_getpagesize();
>      if (qemu_host_page_size == 0)
>          qemu_host_page_size = qemu_real_host_page_size;
>      if (qemu_host_page_size < TARGET_PAGE_SIZE)
>   

This is only used by -linux-user, which does not use osdep.c.

I've reverted this changeset and changed qemu_vmalloc() to just use 
getpagesize().

Regards,

Anthony Liguori