Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support

[François Revol]

> > -    /* TODO: Implement compressed images.  */
> > -    if (hdr->ih_comp != IH_COMP_NONE) {
> > -        fprintf(stderr, "Unable to load compressed u-boot images\
> > n");
> > +    /* TODO bzip2 support */
> > +    if (hdr->ih_comp == IH_COMP_BZIP2) {
> > +        fprintf(stderr, "Unable to load bzip2 compressed u-boot
> > images\n");
> >          goto fail;
> >      }
> why do you remove the non compress mode?

He didn't remove it, he changed the check to only reject BZIP2, not
uncompressed (which is wrong though as it'd accept any other compession
including unknown).

> BTW Please note 2 thinks
> First this format of uImage is deprecated
> we have switch to a fdt uImage format

fdt ? as in flat device tree ?
Is that documented somewhere ?
I'll need to add U-Boot support to Haiku soon...

François.