qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/6] kvm: memory aliasing support for kvm


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 1/6] kvm: memory aliasing support for kvm
Date: Wed, 19 Nov 2008 09:07:06 -0600
User-agent: Thunderbird 2.0.0.17 (X11/20080925)

Glauber Costa wrote:
We use information encoded in phys_offset to support memory
alias for kvm-all.c. Recall that for any given memory slot,
userspace_addr = phys_ram_base + phys_offset (without any flags).

This way, we can detect whether or not the registered slot is
effectively pointing to the same area, regardless of the fact
that it has a different guest_phys_addr.

I think we've missed the abstraction here. If you added an arch hook for kvm_set_phys_mem(), then you could have hidden the alias stuff entirely within target-i386/x86.c

But we can fix that up later.

Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]