Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute

[Andreas Färber]

Am 30.11.2008 um 13:52 schrieb Stefan Weil:

> Jan Kiszka schrieb:
> > Laurent Desnogues wrote:
> > > On Sun, Nov 30, 2008 at 12:51 PM, Stefan Weil <address@hidden>
> > > wrote:
> > > > Why do we need a new macro instead of just using __attribute__
> > > > ((__noreturn__))?
> > > Don't we need it to prevent gcc-ism from being all over the code?
> >
> > Yep, and that's also why we need wrapping. You can easily define it  
> > away
> > if your compiler doesn't support it. We just need to add the required
> > conditions.
>
> For compilers which don't support __attributes__, a simple
>
> #define __attributes__(dummy) /* dummy */
>
> or an equivalent command line option would eliminate all gcc-isms.
> I don't think we need wrapping, at least not now.

Aren't there GCCs which support __attributes__ but not all of them?
Apple's GCC 4.0.1 comes to mind, which doesn't support visibility  
attributes.

Andreas